fix checksum bug #2401 #2403
Merged
fix checksum bug #2401 #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuntaojun
reviewed
Mar 3, 2020
naming/src/main/java/com/alibaba/nacos/naming/core/Instances.java
Outdated
Show resolved
Hide resolved
chuntaojun
reviewed
Mar 3, 2020
| if (MESSAGE_DIGEST != null) { | ||
| checksum = | ||
| new BigInteger(1, MESSAGE_DIGEST.digest((sb.toString()).getBytes(Charset.forName("UTF-8")))).toString(16); | ||
| if (MESSAGE_DIGEST_LOCAL.get() != null) { |
There was a problem hiding this comment.
Here, you can consider holding the MessageDigest with a local variable to avoid getting again later
There was a problem hiding this comment.
Here, you can consider holding the MessageDigest with a local variable to avoid getting again later
done
chuntaojun
approved these changes
Mar 7, 2020
|
@chuntaojun I have unified the md5 calculation in thread-local way instead of using a lock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fix the checksum bug, refer to #2401
MessageDigest is not safe in multi-thread
Brief changelog
Add a lock to ensure execute success
Verifying this change
see InstancesTest