Skip to content

Fix issue 1317 #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2019
Merged

Fix issue 1317 #1380

merged 6 commits into from
Jun 18, 2019

Conversation

chuntaojun
Copy link
Collaborator

@chuntaojun chuntaojun commented Jun 15, 2019

Please do not create a Pull Request without creating an issue first.

thanks @paderlol and @HaojunRen help

What is the purpose of the change

fix issue #1317

Add a listener when the configuration is obtained

Brief changelog

There are usage scenarios as follows: When the program starts, the user registers the Listener and uses getConfig to obtain the configuration information of the remote end, but does not want to trigger the Listener. Instead, after the getConfig, if the configuration information changes, the Listener is triggered.

Verifying this change

 @Test
public void nacos_addListener_5() throws InterruptedException, NacosException {
    final AtomicInteger count = new AtomicInteger(0);
    final String content = "test-abc";
    final String newContent = "new-test-def";
    boolean result = iconfig.publishConfig(dataId, group, content);
    Assert.assertTrue(result);

    Thread.sleep(3000);

    Listener ml = new AbstractListener() {
        @Override
        public void receiveConfigInfo(String configInfo) {
            count.incrementAndGet();
            System.out.println("Listener receive : [" + configInfo + "]");
            Assert.assertEquals(content, newContent);
        }
    };
    String receiveContent = iconfig.getConfigAndSignListener(dataId, group, 1000, ml);
    System.out.println(receiveContent);

    result = iconfig.publishConfig(dataId, group, newContent);
    Assert.assertTrue(result);

    Assert.assertEquals(content, receiveContent);
    Thread.sleep(3000);

    Assert.assertEquals(1, count.get());
    iconfig.removeListener(dataId, group, ml);
}

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants