Feature get subscribers #1297
Merged
Feature get subscribers #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update jackson version
nkorange
reviewed
Jun 4, 2019
| Map<String, String> paramValues = new HashMap<>(128); | ||
| paramValues.put("serviceName",serviceName); | ||
| paramValues.put("namespaceId",namespaceId); | ||
| paramValues.put("aggregation",String.valueOf(!aggregation)); |
nkorange
reviewed
Jun 4, 2019
| JSONObject result = new JSONObject(); | ||
|
|
||
| try { | ||
| List<Subscriber> subscribers = subscribeManager.getSubscribers(serviceName,namespaceId,aggregation); |
nkorange
reviewed
Jun 4, 2019
| String namespaceId = WebUtils.optional(request, CommonParams.NAMESPACE_ID, | ||
| Constants.DEFAULT_NAMESPACE_ID); | ||
| String serviceName = WebUtils.required(request, CommonParams.SERVICE_NAME); | ||
| boolean aggregation = Boolean.valueOf(WebUtils.required(request,"aggregation")); |
nkorange
reviewed
Jun 4, 2019
| // size = 1 means only myself in the list, we need at least one another server alive: | ||
| while (serverListManager.getHealthyServers().size() <= 1) { | ||
| Thread.sleep(1000L); | ||
| Loggers.EPHEMERAL.info("waiting server list init..."); |
There was a problem hiding this comment.
这里不需要等待，小于等于1直接返回本机的订阅者就行
nkorange
reviewed
Jun 4, 2019
| @Service | ||
| public class SubscribeManager { | ||
|
|
||
| private static final String DATA_ON_SYNC_URL = "/service/subscribers"; |
nkorange
reviewed
Jun 4, 2019
|
|
||
| /** | ||
| * @author Nicholas | ||
| */ |
nkorange
reviewed
Jun 4, 2019
| for (Server server : serverListManager.getHealthyServers()) { | ||
|
|
||
| Map<String, String> paramValues = new HashMap<>(128); | ||
| paramValues.put("serviceName",serviceName); |
|
Related issue is #494 |
nkorange
approved these changes
Jun 17, 2019
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
get the subscriber info by namespaceId、serviceName and aggregation
Brief changelog
Add an interface call in Pushservice to get subscription information from pushClient
Add aggregation judgment to control whether data is single-machine acquisition or cluster acquisition