-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #12773] Fix unfriendly message when adding duplicate permissions or binding relationship. #12926
Conversation
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12926 +/- ##
=============================================
- Coverage 72.25% 72.23% -0.02%
Complexity 9915 9915
=============================================
Files 1301 1301
Lines 41728 41736 +8
Branches 4393 4396 +3
=============================================
Hits 30149 30149
- Misses 9468 9473 +5
- Partials 2111 2114 +3
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
What is the purpose of the change
Resolve the same issues in role management and permission management in the console : #12773.
Brief changelog
Modified com.alibaba.nacos.plugin.auth.impl.roles.NacosRoleServiceImpl.addXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.