-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【ISSUE #12911】将for循环拼接的SQL语句改为Lambda表达式拼接,使得代码简洁清晰,并添加相关测试用例 #12914
【ISSUE #12911】将for循环拼接的SQL语句改为Lambda表达式拼接,使得代码简洁清晰,并添加相关测试用例 #12914
Conversation
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
…,使得代码简洁清晰,并添加相关测试用例
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12914 +/- ##
==========================================
Coverage 72.24% 72.25%
+ Complexity 9916 9913 -3
==========================================
Files 1301 1301
Lines 41728 41718 -10
Branches 4395 4389 -6
==========================================
- Hits 30147 30142 -5
Misses 9467 9467
+ Partials 2114 2109 -5
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…eature/optimize-code-js # Conflicts: # plugin/datasource/src/main/java/com/alibaba/nacos/plugin/datasource/mapper/AbstractMapper.java # plugin/datasource/src/test/java/com/alibaba/nacos/plugin/datasource/mapper/AbstractMapperTest.java
@KomachiSion Could this change be merged? Thank you. |
|
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.