-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE#12583] ProtocolManager代码优化 #12584
Conversation
2e13189
to
a9f73e9
Compare
a9f73e9
to
3ae1580
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12584 +/- ##
==========================================
Coverage 69.64% 69.65%
- Complexity 9418 9422 +4
==========================================
Files 1275 1275
Lines 41226 41232 +6
Branches 4373 4374 +1
==========================================
+ Hits 28712 28719 +7
+ Misses 10435 10432 -3
- Partials 2079 2081 +2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProtocolManager的修改可以采纳。麻烦修改下
consumer.accept(bean); | ||
} catch (NoSuchBeanDefinitionException ignore) { | ||
} | ||
T bean = applicationContext.getBean(requiredType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个修改不合理, 本身语义就是希望不存在时创建, 不影响后续逻辑本身, 显示抛出异常不符合方法语义。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其他类型的异常时正常抛出的, 只有不存在bean的异常会被捕获。
What is the purpose of the change
fix #12583 ProtocolManager可能导致的并发问题
Brief changelog
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.