Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12484] Add a description of the project #12508

Closed
wants to merge 0 commits into from

Conversation

tonycody
Copy link
Contributor

image
As shown above

#12484

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (106a1d5) to head (ba17596).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12508      +/-   ##
=============================================
+ Coverage      69.67%   69.69%   +0.02%     
+ Complexity      9398     9397       -1     
=============================================
  Files           1272     1272              
  Lines          41152    41152              
  Branches        4358     4358              
=============================================
+ Hits           28672    28682      +10     
+ Misses         10413    10404       -9     
+ Partials        2067     2066       -1     
Files Coverage Δ
...m/alibaba/nacos/sys/env/EnvModuleStateBuilder.java 87.50% <ø> (ø)
...c/main/java/com/alibaba/nacos/sys/env/EnvUtil.java 23.95% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106a1d5...ba17596. Read the comment docs.

* @return Instance name,Default empty.
*/
public static String getNacosInstanceName() {
return getProperty(Constants.NACOS_INSTANCE_NAME, StringUtils.EMPTY);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

长度会进行限制吗?

以及内容校验。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种要限制吗?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,稍微限制一下,比如不支持特殊字符(可以参考下namespace

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

长度的话,32个字符是不是就够了,太长了ui也摆不下,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,我处理下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants