Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #12221] console ui accessToken in url #12304

Closed
wants to merge 0 commits into from
Closed

[ISSUE #12221] console ui accessToken in url #12304

wants to merge 0 commits into from

Conversation

webapple
Copy link

@webapple webapple commented Jul 3, 2024

fix issues #12221 。
change accessToken to request header.

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@webapple webapple changed the title fix # #12221 console ui accessToken in url [ISSUES #12221] console ui accessToken in url Jul 4, 2024
@webapple webapple changed the title [ISSUES #12221] console ui accessToken in url [ISSUE #12221] console ui accessToken in url Jul 4, 2024
KomachiSion
KomachiSion requested changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should understand the auth plugin more.

The identityContext is the extension context to save token and more identity information.

@KomachiSion
Copy link
Collaborator

KomachiSion commented Jul 15, 2024 •
edited
Loading

The PR has no any change files?
Does it not finished?

@KomachiSion
Copy link
Collaborator

I see some one else has finished this issue in #12353.

Can you double check whether the PR has completed it?

@webapple
Copy link
Author

@KomachiSion #12353 this PR has completed it.

@webapple webapple requested a review from KomachiSion July 19, 2024 02:15
@webapple webapple closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion Awaiting requested review from KomachiSion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webapple @CLAassistant @KomachiSion