Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#12231): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function. #12243

Closed
wants to merge 1 commit into from

Conversation

Bo-Qiu
Copy link
Contributor

@Bo-Qiu Bo-Qiu commented Jun 18, 2024

What is the purpose of the change

fix(#12231 ): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function.

Brief changelog

fix(#12231 ): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function.

Verifying this change

fix(#12231 ): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function.

… database, the time-related field values need to be set using the time obtained from the database's built-in time function.
"encrypted_data_key"));
PreparedStatement ps = connection.prepareStatement(insertSql, configInfoMapper.getPrimaryKeyGeneratedKeys());
PreparedStatement ps = connection.prepareStatement(insertSql, new String[]{"id"});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么要修改

@@ -17,7 +17,7 @@
package com.alibaba.nacos.plugin.datasource;

import com.alibaba.nacos.plugin.datasource.constants.DataSourceConstant;
import com.alibaba.nacos.plugin.datasource.mapper.AbstractMapper;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来的这个AbstractMapper要保留,保证其他插件实现方的兼容

@Bo-Qiu Bo-Qiu closed this Jun 18, 2024
@Bo-Qiu Bo-Qiu deleted the fix/12231 branch June 18, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants