[ISSUE #12196] FIX prometheus http sd invalid label names #12239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fix #12196
Brief changelog
prometheus http sd contains label names with "." and "-", which can not parsed by prometheus, this commit auto connvert invalid words to "_" to make prometheus happy.
label "preserved.register.source":"SPRING_CLOUD" is auto added by nacos sdk,
and another example is label "management.endpoints.web.base-path":"/xxxx" , which auto exported by nacos sdk, label name contains two invalid words . and - .
above 2 label name are not controlled or registered by enduser, and prometheus can't parse these label names, then this scrape job failed, this job results show nothing.
this commit convert label name from . and - words to_ in prometheus/src/main/java/com/alibaba/nacos/prometheus/utils/PrometheusUtils.java only affect prometheus exporter info.
Verifying this change
test pass with latest prometheus.
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.