[ISSUE #747、#1154] Add create and update service methods in SDK and update instance operation #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1069 Increase the URL length limit for temporary solution
nkorange
reviewed
May 7, 2019
api/src/main/java/com/alibaba/nacos/api/naming/MaintainService.java
Outdated
Show resolved
Hide resolved
nkorange
reviewed
May 7, 2019
api/src/main/java/com/alibaba/nacos/api/naming/MaintainService.java
Outdated
Show resolved
Hide resolved
nkorange
reviewed
May 7, 2019
api/src/main/java/com/alibaba/nacos/api/naming/MaintainService.java
Outdated
Show resolved
Hide resolved
nkorange
reviewed
May 7, 2019
nkorange
reviewed
May 7, 2019
client/src/test/java/com/alibaba/nacos/client/naming/NacosMaintainServiceTest.java
Outdated
Show resolved
Hide resolved
nkorange
reviewed
May 7, 2019
client/src/main/java/com/alibaba/nacos/client/naming/NacosMaintainService.java
Outdated
Show resolved
Hide resolved
nkorange
reviewed
May 7, 2019
client/src/main/java/com/alibaba/nacos/client/naming/NacosNamingService.java
Outdated
Show resolved
Hide resolved
chuntaojun
changed the title
nkorange
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Add create and update service methods in SDK
Nacos Client supports the update of service instances' metadata
Brief changelog
Add, delete, and update services to Nacos SDK
update instance to Nacos SDK
Verifying this change
MaintainService_ITCase