[ISSUE #963] to support registering instance with host name #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkorange
reviewed
Apr 19, 2019
naming/src/main/java/com/alibaba/nacos/naming/core/Instance.java
Outdated
Show resolved
Hide resolved
|
@nkorange 这样改完ok了吗？ |
能不能在只包含数字和点的情况下，依然校验IP的有效性？然后在包含英文字母时才不校验，这样感觉好一点。 |
|
@Albert-Hugo 看到你的修改了，很赞！如果再加上几个单元测试用例就完美了 😁 |
单元测试在本地跑了，因为还不熟悉这里的测试案例模式,下次修复其他的问题的时候补上 |
nkorange
approved these changes
Apr 23, 2019
|
@Albert-Hugo 感谢！已经合并。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
To support registering instance with host name
Brief changelog
Only ip address contain ':' will be validated ip format.