Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClusterVersionJudgement ClusterVersionJudge Task never stop #7971

Closed
ye213 opened this issue Mar 22, 2022 · 0 comments
Closed

ClusterVersionJudgement ClusterVersionJudge Task never stop #7971

ye213 opened this issue Mar 22, 2022 · 0 comments
Labels
kind/enhancement Category issues or prs related to enhancement.

Comments

@ye213
Copy link
Contributor

ye213 commented Mar 22, 2022

Describe the bug
In the class 【com.alibaba.nacos.naming.consistency.persistent.ClusterVersionJudgement】,there is a bug
The obj of this class alway submit a task【runVersionListener】to execute ClusterVersionJudge，even when 【allMemberIsNewVersion == true】，which is redundant

Expected behavior
when 【allMemberIsNewVersion == true】 and already execute 【notifyAllListener】，do not execute 【GlobalExecutor.submitClusterVersionJudge(this::runVersionListener, TimeUnit.SECONDS.toMillis(5));】again

Acutally behavior
alway execute 【GlobalExecutor.submitClusterVersionJudge(this::runVersionListener, TimeUnit.SECONDS.toMillis(5));】
ye213 added a commit to ye213/nacos that referenced this issue Mar 22, 2022
@ye213
fix bug(alibaba#7971) ClusterVersionJudgement ClusterVersionJudge Tas…
e9cb1bc 
…k never stop
@ye213 ye213 mentioned this issue Mar 22, 2022
Merged
@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Mar 23, 2022
ye213 added a commit to ye213/nacos that referenced this issue Mar 23, 2022
@ye213
fix bug(alibaba#7971) change code style
547f92b
KomachiSion pushed a commit that referenced this issue Mar 28, 2022
@ye213
[ISSUE #7971] fix ClusterVersionJudgement#ClusterVersionJudge Task ne…
71440a9 
…ver stop (#7972)

* fix bug(#7971) ClusterVersionJudgement ClusterVersionJudge Task never stop

* fix bug(#7971) change code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ye213 @KomachiSion