Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests to package com.alibaba.nacos.naming.controllers in nacos 2.0 #5519

Closed
realJackSun opened this issue Apr 28, 2021 · 2 comments · Fixed by #6414
Closed

Add unit tests to package com.alibaba.nacos.naming.controllers in nacos 2.0 #5519

realJackSun opened this issue Apr 28, 2021 · 2 comments · Fixed by #6414
Labels
area/Test
Milestone
2.0.3

Comments

@realJackSun
Copy link
Collaborator

realJackSun commented Apr 28, 2021 •
edited
Loading

This is a sub-issue of #4982

Issue Description

Type: bug report or feature request

Describe what happened (or what feature you want)

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?
@realJackSun realJackSun mentioned this issue Apr 28, 2021
Open
8 tasks
@realJackSun realJackSun changed the title Add unit tests to package com.alibaba.nacos.client.naming.controllers in nacos 2.0 Add unit tests to package com.alibaba.nacos.naming.controllers in nacos 2.0 Apr 28, 2021
@tangyunxun
Copy link

@i will solve it@

@brotherlu-xcq
Copy link
Collaborator

@tangyunxun Do you still work on this? if no, I will continue the left work.

brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 21, 2021
@brotherlu-xcq
[ISSUE alibaba#5519] complete CatalogControllerTest.
a2e7209
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 21, 2021
@brotherlu-xcq
[ISSUE alibaba#5519] add unit test in controllers, not include deprec…
43c8494 
…ated method.
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 21, 2021
@brotherlu-xcq
[ISSUE alibaba#5519] fix ci issue.
343d897
@brotherlu-xcq brotherlu-xcq mentioned this issue Jul 21, 2021
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Jul 22, 2021
@brotherlu-xcq
[ISSUE #5519] Add unit tests to package com.alibaba.nacos.naming.cont…
a64f5b5 
…rollers in nacos 2.0. (#6414)

* [ISSUE #5519] complete CatalogControllerTest.

* [ISSUE #5519] add unit test in controllers, not include deprecated method.

* [ISSUE #5519] fix ci issue.
@KomachiSion KomachiSion added this to the 2.0.3 milestone Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/Test
Projects
None yet
Milestone
2.0.3
4 participants
@tangyunxun @brotherlu-xcq @KomachiSion @realJackSun