Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nacos-client module http client replace #3224

Closed
2 tasks done
Maijh97 opened this issue Jul 2, 2020 · 1 comment
Closed
2 tasks done

nacos-client module http client replace #3224

Maijh97 opened this issue Jul 2, 2020 · 1 comment
Assignees
@Maijh97
Labels
area/Nacos Core kind/refactor
Milestone
1.3.2

Comments

@Maijh97
Copy link
Collaborator

Maijh97 commented Jul 2, 2020 •
edited
Loading

Issue Description

Type: feature request

Describe what happened (or what feature you want)

Related #3192

Since the nacos-client module involves more http requests,
it is split into naming, config replace task according to the package.

replace task:

  • naming

  • config

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?
@Maijh97 Maijh97 mentioned this issue Jul 2, 2020
Closed
@Maijh97 Maijh97 mentioned this issue Jul 16, 2020
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Jul 18, 2020
@Maijh97
[ISSUE #3224]nacos-client module http client replace (#3348)
63a4e30 
* nacos-client module http client replace

* fix code style problem

* add HashMap initialCapacity

* fix code style problem

* Modify the header object, keep the original response header to avoid modifying the original logic code

* fix code style problem

* naming http client request exception messages output change

* Merge code
@Maijh97
Copy link
Collaborator Author

Maijh97 commented Jul 20, 2020

At present, the http client of nacos-client module has been replace, this issue can be closed. @KomachiSion

@KomachiSion KomachiSion added this to the 1.3.2 milestone Jul 24, 2020
@KomachiSion KomachiSion mentioned this issue Aug 4, 2020
Merged
5 tasks
@snyk-bot snyk-bot mentioned this issue Dec 28, 2021
Open
@snyk-bot snyk-bot mentioned this issue Sep 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maijh97 Maijh97

Labels
area/Nacos Core kind/refactor
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
2 participants
@KomachiSion @Maijh97