Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncNotifyService bugfix and optimization #1453

Closed
zhaoyuguang opened this issue Jul 1, 2019 · 1 comment · Fixed by #1454
Closed

AsyncNotifyService bugfix and optimization #1453

zhaoyuguang opened this issue Jul 1, 2019 · 1 comment · Fixed by #1454
Labels
kind/bug Category issues or prs related to bug.

Comments

@zhaoyuguang
Copy link
Contributor

The problem in AsyncNotifyService.class may need to be fixed

  1. The log parameters are incorrect, causing the log to not output as expected.
  2. Creates an useless Object array object when the log is used because variable parameters are already supported.
  3. Spelling mistake.
  4. Multiple repetitions of code can be optimized.
@nacos-bot nacos-bot added the kind/bug Category issues or prs related to bug. label Jul 1, 2019
@zhaoyuguang
Copy link
Contributor Author

@zhaoyuguang I will solve it #1453

@zhaoyuguang zhaoyuguang mentioned this issue Jul 1, 2019
Merged
5 tasks
nkorange added a commit that referenced this issue Jul 2, 2019
@nkorange
Merge pull request #1454 from zhaoyuguang/zen1
702289a 
Fix #1453
@nacos-bot nacos-bot mentioned this issue Jul 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1453 zhaoyuguang/nacos
2 participants
@zhaoyuguang @nacos-bot