Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin][Bug]Auth Plugin resource parser can't parser v2 config openAPI namespaceId. #12333

Closed
KomachiSion opened this issue Jul 10, 2024 · 1 comment
Closed

[Plugin][Bug]Auth Plugin resource parser can't parser v2 config openAPI namespaceId. #12333

KomachiSion opened this issue Jul 10, 2024 · 1 comment
Labels
contribution welcome kind/bug Category issues or prs related to bug. plugin
Milestone
2.4.0

Comments

@KomachiSion
Copy link
Collaborator

Describe the bug
Resource Parser is auth plugin basic to generator resource from request.
For current config resource parser, it only get namespace Id from http request with parameter tenant, which is used in v1 openAPI for config module to request namespace.

But after version 2.2, Nacos add v2 openAPI and the namespace parameter is unified to namespaceId. So the resource parser need to support parse v2 openAPI.

Expected behavior
It can parse right resource for v2 openAPI.

Actually behavior
Config module resource parser lose the namespaceId for v2 openAPI.

Desktop (please complete the following information):

  • Version nacos 2.2.0 ~ latest(2.3.3)
  • Module config
@KomachiSion KomachiSion added contribution welcome kind/bug Category issues or prs related to bug. plugin labels Jul 10, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone Jul 10, 2024
@Bo-Qiu
Copy link
Contributor

Bo-Qiu commented Jul 10, 2024

I'll fix it, please assign it to me, thx!

Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Jul 10, 2024
@Bo-Qiu
fix(alibaba#12333): fixed auth Plugin resource parser can't parser v2…
41779b1 
… config openAPI namespaceId.
@Bo-Qiu Bo-Qiu mentioned this issue Jul 10, 2024
Merged
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Jul 16, 2024
@Bo-Qiu
fix(alibaba#12333): fixed auth Plugin resource parser can't parser v2…
1684ecc 
… config openAPI namespaceId.
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Jul 16, 2024
@Bo-Qiu
fix(alibaba#12333): fixed auth Plugin resource parser can't parser v2…
f5af698 
… config openAPI namespaceId.
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Jul 16, 2024
@Bo-Qiu
fix(alibaba#12333): fixed auth Plugin resource parser can't parser v2…
f7cc9d5 
… config openAPI namespaceId.
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Jul 16, 2024
@Bo-Qiu
fix(alibaba#12333): fixed auth Plugin resource parser can't parser v2…
ba2861a 
… config openAPI namespaceId.

fix(alibaba#12333): fixed auth Plugin resource parser can't parser v2 config openAPI namespaceId.
KomachiSion pushed a commit that referenced this issue Jul 18, 2024
@Bo-Qiu
fix(#12333): fixed auth Plugin resource parser can't parser v2 config…
1879c81 
… openAPI namespaceId. (#12336)

fix(#12333): fixed auth Plugin resource parser can't parser v2 config openAPI namespaceId.
lowezheng added a commit to lowezheng/nacos that referenced this issue Jul 24, 2024
@lowezheng
Merge commit '197795a854992d3f88824e4cdde34c61d8f56cf4' into develop-…
336260f 
…apexsoft

* commit '197795a854992d3f88824e4cdde34c61d8f56cf4': (225 commits)
  Fix alibaba#12395, use request context replace session depend. (alibaba#12398)
  Revert "Add an id primary key column to both the roles and permissions tables.（mysql-schema.sql） (alibaba#12206)" (alibaba#12396)
  Upgrade to 2.4.0 (alibaba#12384)
  Develop support ram info switch (alibaba#12382)
  Close derby ops api default. (alibaba#12372)
  Upgrade grpc to 1.64.2 (alibaba#12369)
  fix(alibaba#12333): fixed auth Plugin resource parser can't parser v2 config openAPI namespaceId. (alibaba#12336)
  Adjust integration tests for common modules in the core module to comply with checkstyle. (alibaba#12349)
  [IT]Adjust integration tests for cluster,code,smoke modules in the core module to comply with checkstyle. (alibaba#12350)
  fix [ISSUE alibaba#12323] , using the project's logback packagingData configuration instead of logback-nacos.xml's packagingData configuration (alibaba#12360)
  Remove the accessToken from the URL. (alibaba#12353)
  feat(alibaba#12355): Record the cost of ConfigDump in Prometheus. (alibaba#12356)
  [IT]Adjust core module auth integration tests to meet checkstyle requirements. (alibaba#12368)
  [ISSUE alibaba#12282]Fix the issue where monitoring data cannot be found through the IP dimension in the ListeningQuery (alibaba#12315)
  Adjust integration tests for ability, base, and client modules in the core module to comply with checkstyle. (alibaba#12335)
  Develop refactor request context (alibaba#12331)
  fix unexpect exception from NetworkInterface.ifUp (alibaba#12325)
  fix(alibaba#12231): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function. (alibaba#12244)
  add some UT for default auth plugin (alibaba#12318)
  [ISSUE alibaba#12219] 修复nacos-client中config的ServerListManager解析endpoint失败问题 (alibaba#12220)
  ...

# Conflicts:
#	plugin-default-impl/nacos-default-auth-plugin/src/main/java/com/alibaba/nacos/plugin/auth/impl/persistence/ExternalPermissionPersistServiceImpl.java
#	pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome kind/bug Category issues or prs related to bug. plugin
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
2 participants
@KomachiSion @Bo-Qiu