[ISSUE#9323]1.x http接口服务名校验问题 (#9324)

* 1.x http接口服务名校验问题 * 1.x http接口服务名校验问题 for #9323
alibaba · Oct 14, 2022 · 0834641 · 0834641 · wuchubuzai2018 · Oct 14, 2022
1 parent 0bfd752
commit 0834641
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/naming/src/main/java/com/alibaba/nacos/naming/web/ServiceNameFilter.java b/naming/src/main/java/com/alibaba/nacos/naming/web/ServiceNameFilter.java
@@ -18,9 +18,10 @@
 
 import com.alibaba.nacos.api.common.Constants;
 import com.alibaba.nacos.api.naming.CommonParams;
+import com.alibaba.nacos.api.naming.utils.NamingUtils;
 import com.alibaba.nacos.common.utils.ExceptionUtil;
-import com.alibaba.nacos.core.utils.OverrideParameterRequestWrapper;
 import com.alibaba.nacos.common.utils.StringUtils;
+import com.alibaba.nacos.core.utils.OverrideParameterRequestWrapper;
 
 import javax.servlet.Filter;
 import javax.servlet.FilterChain;
@@ -63,6 +64,14 @@ public void doFilter(ServletRequest servletRequest, ServletResponse servletRespo
             if (StringUtils.isNotBlank(serviceName) && !serviceName.contains(Constants.SERVICE_INFO_SPLITER)) {
                 groupedServiceName = groupName + Constants.SERVICE_INFO_SPLITER + serviceName;
             }
+            if (StringUtils.isNotBlank(groupedServiceName)) {
+                try {
+                    NamingUtils.checkServiceNameFormat(groupedServiceName);
+                } catch (IllegalArgumentException e) {
+                    resp.sendError(HttpServletResponse.SC_BAD_REQUEST,
+                            "Service name filter error," + ExceptionUtil.getAllExceptionMsg(e));
+                }
+            }
             OverrideParameterRequestWrapper requestWrapper = OverrideParameterRequestWrapper.buildRequest(request);
             requestWrapper.addParameter(CommonParams.SERVICE_NAME, groupedServiceName);
             filterChain.doFilter(requestWrapper, servletResponse);