feat: prom support tls plaintext #2002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messixukejia
requested changes
Dec 31, 2024
| for (auto& c : tmpJobName) { | ||
| c = (c == '/') ? '_' : c; | ||
| } | ||
| string caFile = "/tmp/" + tmpJobName + "_ca.pem"; |
There was a problem hiding this comment.
/tmp固定这种实现基本上都是不合理的
看上去整个实现从流程上不太合理，先评审下设计吧
quzard
requested changes
Jan 1, 2025
| @@ -353,6 +353,21 @@ void ScrapeConfig::InitEnableCompression(bool enableCompression) { | |||
| } | |||
|
|
|||
| bool ScrapeConfig::InitTLSConfig(const Json::Value& tlsConfig) { | |||
There was a problem hiding this comment.
conf文件应该写在AppConfig::GetInstance()->GetLoongcollectorConfDir()这个目录里
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.