Fix apsara base field parse error and microsecond handling in Apsara log parser #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser previously used microsecond incorrectly in the time cache. Now only the time in second is properly retrieved from the cache. And the microsecond part is always parsed from log timestamps. Additionally, a bounds check has been added to prevent out-of-range array access, ensuring reliable operation.
quzard
changed the title
quzard
changed the title
henryzhx8
pushed a commit
that referenced
this pull request
Jan 20, 2025
Link: https://code.alibaba-inc.com/sls/ilogtail/codereview/15172513 * upgrade to V2 config * Fix apsara base field parse error and microsecond handling in Apsara log parser (#1308) The parser previously used microsecond incorrectly in the time cache. Now only the time in second is properly retrieved from the cache. And the microsecond part is always parsed from log timestamps. Additionally, a bounds check has been added to prevent out-of-range array access, ensuring reliable operation. --------- Co-authored-by: Tom Yu <[email protected]> * remove deprecated LogParse class (#1310) * remove deprecated LogParse class * Added a switch to control the loading of the processor_spl, which by default remains unloaded. (#1312) * add switch * Merge remote-tracking branch 'upstream/main' into feat/refactor * Added a switch to control the loading of the processor_spl, which by default remains unloaded. (#1312) * add switch * Fix memory leak by deleting unused log readers during container update (#1314) During refactor, function DeleteHandlers() is altered so that only called during pipeline update, not on container update. This would lead to memory leak in k8s. * Merge remote-tracking branch 'upstream/main' into feat/refactor * Fix log group memory leak when using Golang plugins and reduce alarm frequency in LOGSTORE send mode (#1313) 1. Fixed the issue where the logGroup pointer was not released when using Golang plugins. 2. Increase alarm threshold and reduce 'package list interval' configuration to fix the alarm of LOG_GROUP_WAIT_TOO_LONG_ALARM in LOGSTORE mode. * Merge remote-tracking branch 'origin/main' into feat/refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser previously used microsecond incorrectly in the time cache. Now only the time in second is properly retrieved from the cache. And the microsecond part is always parsed from log timestamps.
Additionally, a bounds check has been added to prevent out-of-range array access, ensuring reliable operation.