Fix: remove content if native processor parse failed #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the native processors chose to keep both source key and __raw_log__ if parsing fails and keeping unmatched content is desired. Keeping unmatched content in __raw_log__ is to be compatible with older version. Keeping unmatched content in the source key is convenient if one want data to fall through the next processor when the previous one fails and such behavior is consistent with the behavior of the Go plugin. However, this could result in a doubling of the data volume. As connecting multiple native parsers or connecting native parsers with Go processors is rare now, after this patch only __raw_log__ will be kept. If one want to process the data that previous native processor fails, __raw_log__ must be configured as the source_key in the next processor.
messixukejia
requested changes
Jan 2, 2024
| @@ -121,6 +121,8 @@ bool ProcessorParseApsaraNative::ProcessEvent(const StringView& logPath, | |||
| mProcParseErrorTotal->Add(1); | |||
| ++(*mParseFailures); | |||
| if (!mDiscardUnmatch) { | |||
| sourceEvent.DelContent(mSourceKey); | |||
| mProcParseOutSizeBytes->Add(-mSourceKey.size() - buffer.size()); | |||
There was a problem hiding this comment.
因为log加到__raw_log__，并且从content key中删除了，删除的部分减掉。
messixukejia
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the native processors chose to keep both source key and raw_log if parsing fails and keeping unmatched content is desired. Keeping unmatched content in raw_log is to be compatible with older version.
Keeping unmatched content in the source key is convenient if one want data to fall through the next processor when the previous one fails and such behavior is consistent with the behavior of the Go plugin. However, this could result in a doubling of the data volume. As connecting multiple native parsers or connecting native parsers with Go processors is rare now, after this patch only raw_log will be kept. If one want to process the data that previous native processor fails, raw_log must be configured as the source_key in the next processor.