feat: support prometheus self monitor, add 9 metrics for prom input plugin #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
catdogpandas
commented
Sep 13, 2024
catdogpandas
commented
| 指标 | 描述 | labels | 类型 |
|---|---|---|---|
| prom_register_state | 注册状态 | pod_name,operator_host,operator_port | IntGauge |
| prom_register_retry_total | 注册重试 | status,pod_name,... | Counter |
| prom_job_num | 输入插件（Job）数量 | pod_name,... | IntGauge |
| prom_subsricbe_targets | 订阅的 Targets 数量 | job,pod_name,... | IntGauge |
| prom_subsricbe_total | 订阅次数总量 | status,job,pod_name,... | Counter |
| prom_subsricbe_time_ms | 订阅耗时（分布） | status,job,pod_name,... | IntGauge |
| prom_scrape_total | 采集次数总量 | status,target,job,pod_name,... | Counter |
| prom_scrape_bytes_total | 采集总字节数 | status,target,job,pod_name,... | Counter |
| prom_scrape_time_ms | 采集耗时（分布） | status,target,job,pod_name,... | IntGauge |
Takuka0311
requested changes
Sep 13, 2024
Takuka0311
requested changes
Sep 14, 2024
linrunqi08
requested changes
Sep 20, 2024
| if (!mMetricsCounterMap.count(metricName) || !mMetricsCounterMap[metricName].count(status)) { | ||
| mMetricsCounterMap[metricName][status] = GetOrCreateReentrantMetricsRecordRef(status)->GetCounter(metricName); | ||
| } | ||
| mMetricsCounterMap[metricName][status]->Add(val); |
There was a problem hiding this comment.
这里不要用map存储查找，具体原则可以再找玄飏对齐一下
There was a problem hiding this comment.
status 3XX，4XX，5XX这样是不是就好了？不需要具体的code吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.