bugfix: waiting containers block pod termination #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjtufl
reviewed
Oct 10, 2023
hhyasdf
force-pushed
the
bugfix/waiting-containers-block-pod-termination
branch
from
a39c114
to
79a8d46
Compare
hhyasdf
force-pushed
the
bugfix/waiting-containers-block-pod-termination
branch
from
79a8d46
to
edd4a15
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
- Coverage 41.45% 41.38% -0.08%
==========================================
Files 42 42
Lines 2757 2757
==========================================
- Hits 1143 1141 -2
- Misses 1498 1500 +2
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hhyasdf
pushed a commit
to hhyasdf/hybridnet
that referenced
this pull request
Oct 10, 2023
…-block-pod-termination bugfix: waiting containers block pod termination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Describe what this PR does / why we need it
As mentioned in #406, now sts pods might get stuck in "Terminating" because of unknow waiting container state. To check if pod is completely terminated, we should check if "all the containers' state are not running" rather than "all the containers‘ state are terminated".
Does this pull request fix one issue?
Fixes #406
Describe how you did it
Describe how to verify it
Special notes for reviews