Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce update-ipinstance-status for daemon #402

Conversation

hhyasdf
Copy link
Collaborator

@hhyasdf hhyasdf commented Sep 20, 2023

Pull Request Description

Describe what this PR does / why we need it

So we can make daemon donot update status for ipinstance. And remove status.phase field for IPInstance, which is useless.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@hhyasdf hhyasdf force-pushed the feature/introduce-update-ipinstance-status-for-daemon branch from d71a29b to 9d724ae Compare September 21, 2023 01:55
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.07% 🎉

Comparison is base (02d9652) 41.30% compared to head (9d724ae) 41.37%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   41.30%   41.37%   +0.07%     
==========================================
  Files          42       42              
  Lines        2753     2753              
==========================================
+ Hits         1137     1139       +2     
+ Misses       1499     1498       -1     
+ Partials      117      116       -1     
Flag Coverage Δ
unittests 41.37% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/apis/networking/v1/ipinstance_types.go 100.00% <ø> (ø)
pkg/controllers/networking/pod_controller.go 50.26% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mars1024 mars1024 merged commit b5f6c0c into alibaba:main Sep 21, 2023
8 checks passed
hhyasdf pushed a commit to hhyasdf/hybridnet that referenced this pull request Sep 21, 2023
…ipinstance-status-for-daemon

feat: introduce update-ipinstance-status for daemon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants