Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ipset pkg #215

Merged
merged 1 commit into from
Apr 8, 2022
Merged

update ipset pkg #215

merged 1 commit into from
Apr 8, 2022

Conversation

hhyasdf
Copy link
Collaborator

@hhyasdf hhyasdf commented Apr 8, 2022

Pull Request Description

Describe what this PR does / why we need it

  1. Update "ipset" pkg to the latest version of kube-router and fix license.
  2. Remove the "ipset save" operation which might return an error.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #215 (0f59cf8) into main (682be94) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   27.71%   27.71%           
=======================================
  Files          23       23           
  Lines        1656     1656           
=======================================
  Hits          459      459           
  Misses       1145     1145           
  Partials       52       52           
Flag Coverage Δ
unittests 27.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682be94...0f59cf8. Read the comment docs.

Copy link
Collaborator

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@mars1024 mars1024 merged commit 0dbde8a into alibaba:main Apr 8, 2022
@hhyasdf hhyasdf deleted the improve/update-ipset branch April 18, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants