Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useTitle hook #490

Merged
merged 11 commits into from
Jul 10, 2020
Merged

feat: add useTitle hook #490

merged 11 commits into from
Jul 10, 2020

Conversation

chenbin92
Copy link
Collaborator

No description provided.

@brickspert
Copy link
Collaborator

CI 看一下?~

Copy link
Collaborator

@brickspert brickspert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brickspert brickspert requested a review from awmleer July 7, 2020 02:09
@awmleer awmleer added this to the v2.2.0 milestone Jul 8, 2020
@awmleer awmleer self-assigned this Jul 8, 2020
const titleRef = useRef(document.title);
document.title = title;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果父子组件中都 useTitle 的话,是不是会出现覆盖顺序的问题?

@awmleer awmleer merged commit 31bd49f into master Jul 10, 2020
@awmleer awmleer deleted the feat/useTitle branch July 10, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants