Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace prettier with biome #2629

Merged
merged 2 commits into from
Sep 25, 2024
Merged

chore: replace prettier with biome #2629

merged 2 commits into from
Sep 25, 2024

Conversation

ianzone
Copy link
Contributor

@ianzone ianzone commented Aug 22, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (reduce dev dependencies and improve format speed)

🔗 Related issue link

none

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English none
🇨🇳 Chinese none

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@crazylxr
Copy link
Collaborator

crazylxr commented Sep 22, 2024

这个的替换原因是什么呢,prettier 目前有不满足你的点么,或者说这个替换对于这个仓库有什么收益?

@ianzone
Copy link
Contributor Author

ianzone commented Sep 22, 2024

这个的替换原因是什么呢,prettier 目前有不满足你的点么,或者说这个替换对于这个仓库有什么收益?

  1. biome 由 rust 编写,比 prettier 和 eslint 有更快的检查速度
  2. 使用 biome 代替 prettier 和 eslint 有助于减少依赖项
  3. 由于目前 eslintrc.js 里有较多设置,之后会提新的 pr 逐步替换

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ianzone
❌ crazylxr
You have signed the CLA already but the status is still pending? Let us recheck it.

@crazylxr
Copy link
Collaborator

这个的替换原因是什么呢,prettier 目前有不满足你的点么,或者说这个替换对于这个仓库有什么收益?

  1. biome 由 rust 编写,比 prettier 和 eslint 有更快的检查速度
  2. 使用 biome 代替 prettier 和 eslint 有助于减少依赖项
  3. 由于目前 eslintrc.js 里有较多设置,之后会提新的 pr 逐步替换

好,那尝试一下

@crazylxr crazylxr merged commit 2c0cf89 into alibaba:master Sep 25, 2024
5 of 6 checks passed
@ianzone ianzone deleted the biome branch September 25, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants