Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useExternal): avoid wrong option #2011

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Conversation

vaakian
Copy link
Contributor

@vaakian vaakian commented Dec 20, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

💡 Background and solution

Avoid potential wrong option.

For example, if user specifies type: 'js' then css attribute is useless and will be omitted, this PR can help it at type level.

❌ wrong

image

✅ correct

image

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2022

CLA assistant check
All committers have signed the CLA.

@vaakian vaakian changed the title fix(useExternal): Avoid wrong option fix(useExternal): avoid wrong option Dec 20, 2022
@miracles1919
Copy link
Collaborator

我在你的基础上稍微调整了下,看看这样怎么样

@crazylxr crazylxr merged commit 4d82a07 into alibaba:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants