Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-type: TypeScript 定义更新 #1509

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix-type: TypeScript 定义更新 #1509

merged 2 commits into from
Mar 16, 2022

Conversation

zhao-huo-long
Copy link
Contributor

[English Template / 英文模板]

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

1.类型错误
useDebounceFnuseThrottleFn返回的run方法的函数签名不太严谨, 因为run()执行结果是不可预知的,可能为undefined 可能为原返回值类型.
例子:
image
解决方式:

((...args: any[]) => {
  return fnRef.current(...args);
}) as T

run: debounced as unknown as T

change:

((...args: Parameters<T>): ReturnType<T> => {
   return fnRef.current(...args);
})

run: debounced

按照lodash的run类型导出, 还能减少as any关键字
image

📝 更新日志

语言 更新描述
🇺🇸 英文
🇨🇳 中文

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zhao-huo-long zhao-huo-long changed the title fix-type: fix-type: TypeScript 定义更新 Mar 16, 2022
Copy link
Collaborator

@brickspert brickspert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brickspert brickspert merged commit 7c076d4 into alibaba:master Mar 16, 2022
@zhao-huo-long zhao-huo-long deleted the upgrade-types branch March 24, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants