Merge pull request #815 from Dolov/master

feat: useControllableValue add more callback params
alibaba · Jan 10, 2021 · 2486993 · 2486993
2 parents 515f687 + 38f000f
commit 2486993
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/hooks/src/useControllableValue/__tests__/index.test.ts b/packages/hooks/src/useControllableValue/__tests__/index.test.ts
@@ -25,18 +25,21 @@ describe('useControllableValue', () => {
   });
 
   it('onChange should work', () => {
+    let extraParam: string = ''
     const props = {
       value: 2,
-      onChange(v: any) {
+      onChange(v: any, extra) {
         this.value = v;
+        extraParam = extra
       },
     };
     const hook = setUp(props);
     expect(hook.result.current[0]).toEqual(2);
     act(() => {
-      hook.result.current[1](3);
+      hook.result.current[1](3, 'extraParam');
     });
     expect(props.value).toEqual(3);
+    expect(extraParam).toEqual('extraParam');
   });
 
   it('test on state update', () => {

diff --git a/packages/hooks/src/useControllableValue/index.ts b/packages/hooks/src/useControllableValue/index.ts
@@ -40,12 +40,12 @@ export default function useControllableValue<T>(props: Props = {}, options: Opti
   }, [value, valuePropName]);
 
   const handleSetState = useCallback(
-    (v: T | undefined) => {
+    (v: T | undefined, ...args: any[]) => {
       if (!(valuePropName in props)) {
         setState(v);
       }
       if (props[trigger]) {
-        props[trigger](v);
+        props[trigger](v, ...args);
       }
     },
     [props, valuePropName, trigger],