Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2959 #2960

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix 2959 #2960

merged 2 commits into from
Sep 16, 2024

Conversation

yanxutao89
Copy link
Collaborator

What this PR does / why we need it?

fix consistent with declared orders when alphabetic is false, for issue #2959

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@wenshao wenshao merged commit 4686c2c into main Sep 16, 2024
12 checks passed
@yanxutao89 yanxutao89 deleted the fix-2959 branch September 19, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanxutao89 @wenshao