Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend pull#1419 in incubator-vector #1444

Merged
merged 1 commit into from
May 7, 2023
Merged

Conversation

kraity
Copy link
Collaborator

@kraity kraity commented May 7, 2023

What this PR does / why we need it?

Summary of your change

Amend #1419 in incubator-vector

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (c37d23b) 75.96% compared to head (d1d36f1) 76.02%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1444      +/-   ##
============================================
+ Coverage     75.96%   76.02%   +0.06%     
- Complexity    20165    20187      +22     
============================================
  Files           613      603      -10     
  Lines         79808    79165     -643     
  Branches      17519    17500      -19     
============================================
- Hits          60625    60189     -436     
+ Misses        11955    11744     -211     
- Partials       7228     7232       +4     

see 65 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wenshao wenshao merged commit 0381f41 into alibaba:main May 7, 2023
@kraity kraity deleted the pull1419 branch May 7, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants