Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for castToBigInteger in TypeUtils #1145

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Conversation

metal-huang
Copy link
Contributor

@metal-huang metal-huang commented Feb 25, 2023

What this PR does / why we need it?

应用升级到该兼容包时,由于缺少castToBigInteger 方法导致无法编译。

Summary of your change

为TypeUtil增加castToBigInteger方法。

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Base: 74.48% // Head: 74.48% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (312ed7b) compared to base (73f81c0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1145      +/-   ##
============================================
- Coverage     74.48%   74.48%   -0.01%     
  Complexity    18521    18521              
============================================
  Files           716      716              
  Lines         76401    76402       +1     
  Branches      16378    16378              
============================================
  Hits          56907    56907              
  Misses        12635    12635              
- Partials       6859     6860       +1     
Impacted Files Coverage Δ
...main/java/com/alibaba/fastjson/util/TypeUtils.java 36.34% <100.00%> (+0.07%) ⬆️
...rc/main/java/com/alibaba/fastjson2/JSONReader.java 71.04% <0.00%> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wenshao wenshao merged commit 6551ec5 into alibaba:main Feb 25, 2023
@wenshao wenshao added bug Something isn't working fixed labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants