Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git config wrong email name . reopen another one #97

Closed

Conversation

tigerMoon
Copy link
Contributor

Describe what this PR does / why we need it
add redis implement of Datasource

Does this pull request fix one issue?
Fixes #37

Describe how you did it
use lettuce redis client. and redis pub/sub feature.

Describe how to verify it
run the test case.

Special notes for reviews
no

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tigerMoon
❌ tiger


tiger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sczyh30
Copy link
Member

sczyh30 commented Aug 27, 2018

Hi, thanks for your contribution. The CI indicates a build failure, could you please resolve it?
By the way, please sign the CLA and commit with you GiHub account.

@sczyh30 sczyh30 added the to-review To review label Aug 27, 2018
@tigerMoon
Copy link
Contributor Author

sorry this is my first pr. i have fix the checked problem. but i do not know how to recheck it.

@sczyh30
Copy link
Member

sczyh30 commented Aug 27, 2018

You can see the build failure information in CI details page:
image

And you need to update email in your previous commits.

@tigerMoon tigerMoon closed this Aug 27, 2018
@tigerMoon tigerMoon changed the title add redis data source implement of DataSource email name error. reopen another one Aug 27, 2018
@tigerMoon tigerMoon changed the title email name error. reopen another one git config wrong email name . reopen another one Aug 28, 2018
@tigerMoon tigerMoon deleted the feature-rule-datasource-redis branch August 28, 2018 13:00
@sczyh30 sczyh30 added invalid This doesn't seem right and removed to-review To review labels Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] DataSource integration for Redis
3 participants