Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement for context name in Web Servlet filter #944

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Jul 29, 2019

Describe what this PR does / why we need it

Use the unified context name in Web Servlet filter so that the amount of the context won't exceed the threshold.

Does this pull request fix one issue?

NONE

Describe how you did it

  • Use the unified context name (sentinel_web_servlet_context) instead in Web Servlet filter.
  • Code and document improvement

Describe how to verify it

Run the web demo and see the invocation chain in the dashboard.

Special notes for reviews

NONE

@sczyh30 sczyh30 added area/integrations Issues or PRs related to integrations with open-source components kind/enhancement Category issues or prs related to enhancement. labels Jul 29, 2019
Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 37e78e5 into master Jul 29, 2019
@sczyh30 sczyh30 deleted the enhancement/common-filter branch July 29, 2019 06:41
@sczyh30 sczyh30 added this to the 1.6.3 milestone Jul 29, 2019
sczyh30 added a commit that referenced this pull request Jul 29, 2019
…mprovement (#944)

Signed-off-by: Eric Zhao <[email protected]>

(cherry picked from commit 37e78e5)
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Issues or PRs related to integrations with open-source components kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants