Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that dashboard do not correctly show the SystemRule in CPU usage strategy #927

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

Crazy10552
Copy link
Contributor

it fix the bug that dashboard do not correctly show the system rule(the rule about properties highestCpuUsage)

Does this pull request fix one issue?

Fixes #905

Describe how you did it

  • I add new properties in entity SystemRuleEntity

  • I update the related js and html about System rule

Describe how to verify it

image

Special notes for reviews

i recreate my branch to slove my commit problem of my git account,the previous pull pull922

@codecov-io
Copy link

Codecov Report

Merging #927 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #927      +/-   ##
============================================
- Coverage     42.54%   42.53%   -0.02%     
  Complexity     1441     1441              
============================================
  Files           310      310              
  Lines          8993     8993              
  Branches       1222     1222              
============================================
- Hits           3826     3825       -1     
- Misses         4698     4699       +1     
  Partials        469      469
Impacted Files Coverage Δ Complexity Δ
...tinel/slots/block/flow/param/ParamFlowChecker.java 52.7% <0%> (-2.71%) 28% <0%> (-1%)
...inel/datasource/zookeeper/ZookeeperDataSource.java 66.33% <0%> (-1%) 15% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LeapArray.java 70.29% <0%> (+2.97%) 34% <0%> (+1%) ⬆️
...ava/com/alibaba/csp/sentinel/node/ClusterNode.java 100% <0%> (+4.76%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd20dd...e92b3a3. Read the comment docs.

@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Jul 18, 2019
@sczyh30 sczyh30 changed the title it fix the bug that dashboard do not correctly show the system rule(the rule about properties highestCpuUsage) Fix the problem that dashboard do not correctly show the SystemRule in CPU usage strategy Jul 18, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 5e85965 into alibaba:master Jul 23, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jul 23, 2019

Thanks for contributing! I'll refine the code later.

@sczyh30 sczyh30 added this to the 1.6.3 milestone Jul 23, 2019
sczyh30 added a commit that referenced this pull request Jul 23, 2019
sczyh30 pushed a commit that referenced this pull request Jul 29, 2019
… the SystemRule in CPU usage strategy (#927)

(cherry picked from commit 5e85965)
sczyh30 added a commit that referenced this pull request Jul 29, 2019
Signed-off-by: Eric Zhao <[email protected]>

(cherry picked from commit e50be35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SystemRule usage
3 participants