-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix temp file problem #908
Conversation
using the LongAdder rather than AtomicInteger to Provides better performance
merge master
…perties directory
merge online
…cator to load log config
merge onlie
merge online
This reverts commit d401c2f
Codecov Report
@@ Coverage Diff @@
## master #908 +/- ##
============================================
- Coverage 42.58% 42.53% -0.05%
+ Complexity 1443 1440 -3
============================================
Files 310 310
Lines 8992 8992
Branches 1221 1221
============================================
- Hits 3829 3825 -4
- Misses 4696 4698 +2
- Partials 467 469 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
(cherry picked from commit 61c8397)
[RIP-9] Add English document for Design_Trancation.md
###Describe what this PR does / why we need it
When install
sentinel
project once, temporary files create in theuser.home
dir. Time and time theuser.home
become confused. And I have to remove the tmp file manually. Some times I almost delete the wholeuser.dir
. I think the tmp file should not be created or delete.Does this pull request fix one issue?
fix #881
Describe how you did it
com.alibaba.csp.sentinel.slots.logger.EagleEyeLogUtilTest#testChangeLogBase
com.alibaba.csp.sentinel.RecordLogTest#testChangeLogBase
I remove the @test annotation
Because change
LogBase
It is not not work when integration TestingLogBase.LOG_DIR
can be just static init for once and it will not be changedAnd I fix original verify logic problem.
Describe how to verify it
Special notes for reviews