Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix temp file problem #908

Merged
merged 35 commits into from
Jul 16, 2019
Merged

fix temp file problem #908

merged 35 commits into from
Jul 16, 2019

Conversation

linlinisme
Copy link
Collaborator

###Describe what this PR does / why we need it
When install sentinel project once, temporary files create in the user.home dir. Time and time the user.home become confused. And I have to remove the tmp file manually. Some times I almost delete the whole user.dir. I think the tmp file should not be created or delete.

Does this pull request fix one issue?

fix #881

Describe how you did it

com.alibaba.csp.sentinel.slots.logger.EagleEyeLogUtilTest#testChangeLogBase
com.alibaba.csp.sentinel.RecordLogTest#testChangeLogBase
I remove the @test annotation
Because change LogBase It is not not work when integration Testing
LogBase.LOG_DIR can be just static init for once and it will not be changed

And I fix original verify logic problem.

Describe how to verify it

Special notes for reviews

Lin.Liang and others added 30 commits May 9, 2019 14:54
using the LongAdder rather than AtomicInteger to Provides better performance
@codecov-io
Copy link

Codecov Report

Merging #908 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #908      +/-   ##
============================================
- Coverage     42.58%   42.53%   -0.05%     
+ Complexity     1443     1440       -3     
============================================
  Files           310      310              
  Lines          8992     8992              
  Branches       1221     1221              
============================================
- Hits           3829     3825       -4     
- Misses         4696     4698       +2     
- Partials        467      469       +2
Impacted Files Coverage Δ Complexity Δ
...ava/com/alibaba/csp/sentinel/node/ClusterNode.java 95.23% <0%> (-4.77%) 7% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LeapArray.java 67.32% <0%> (-2.98%) 33% <0%> (-1%)
...ain/java/com/alibaba/csp/sentinel/log/LogBase.java 56.94% <0%> (ø) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 326dd44...6302e82. Read the comment docs.

@sczyh30 sczyh30 added area/test Issue or PR related to test cases to-review To review labels Jul 12, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 61c8397 into alibaba:master Jul 16, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jul 16, 2019

Thanks!

@sczyh30 sczyh30 removed the to-review To review label Jul 16, 2019
sczyh30 pushed a commit that referenced this pull request Jul 29, 2019
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
[RIP-9] Add English document for Design_Trancation.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Issue or PR related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove the tmpLog dir
3 participants