Fix the bug that numeric overflow might occur when refilling tokens in ParamFlowChecker #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n ParamFlowChecker - use AtomicLong to replace AtomicInteger Signed-off-by: Eric Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao [email protected]
Describe what this PR does / why we need it
Fix the bug that numeric overflow might occur when refilling tokens in
ParamFlowChecker:https://github.com/alibaba/Sentinel/blob/1.6.1/sentinel-extension/sentinel-parameter-flow-control/src/main/java/com/alibaba/csp/sentinel/slots/block/flow/param/ParamFlowChecker.java#L168
In the scenario of infrequent API invocations, when the
passTime(i.e. time duration from the last request) andtokenCountare both large, thetoAddCountmight overflow.Does this pull request fix one issue?
Fixes #837
Describe how you did it
Use
longinstead ofint. The internal has been replaced withAtomicLong.Describe how to verify it
Run the test cases.
Special notes for reviews
NONE