Enhancements for handling Error in InitExecutor and LogBase #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in LogBase - to avoid affecting normal logic of users Signed-off-by: Eric Zhao <[email protected]>
blindpirate
pushed a commit
to blindpirate/Sentinel
that referenced
this pull request
Apr 10, 2019
… in LogBase (alibaba#613) to avoid affecting normal logic of users Signed-off-by: Eric Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao [email protected]
Describe what this PR does / why we need it
Enhancements for handling
Errorin InitExecutor and LogBase so that it won't affect the normal logic.Does this pull request fix one issue?
Closes #583, also resolves #563
Describe how you did it
Errorcaught inInitExecutor.doInit()to avoidNoClassDefFoundErrorduring initalization.LogBasecannot be initialized, it won't exit the process directly.InitExecutor.doInit().Describe how to verify it
Run the demo.
Special notes for reviews
None