-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authentication info parameter in the constructor of ZooKeeperDataSource to support authentication #508
Conversation
Hi, thanks for contributing. Could you please sign the CLA here? |
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
============================================
+ Coverage 37.66% 37.77% +0.11%
- Complexity 1099 1104 +5
============================================
Files 259 259
Lines 8159 8171 +12
Branches 1111 1113 +2
============================================
+ Hits 3073 3087 +14
+ Misses 4690 4688 -2
Partials 396 396
Continue to review full report at Codecov.
|
Hello, signing done. |
Could you please illustrate your design in the PR description? |
您好,在ZookeeperDataSource中增加了一个新的构造方法 另外在 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice, thanks for contributing! |
The constructor method of
ZooKeeperDataSource
adds authentication information to support authentication.Resolves #501