-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ApiCommandHandler which fetch all registered CommandHandlers so that user can get all available CommandHandlers by request /api #491
Conversation
… that user can get all available CommandHandlers by request /api
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
============================================
+ Coverage 37.66% 38.19% +0.53%
- Complexity 1099 1114 +15
============================================
Files 259 259
Lines 8159 8173 +14
Branches 1111 1113 +2
============================================
+ Hits 3073 3122 +49
+ Misses 4690 4643 -47
- Partials 396 408 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please reformat your code using the Alibaba P3C plugin.
...ansport-common/src/main/java/com/alibaba/csp/sentinel/command/annotation/CommandMapping.java
Show resolved
Hide resolved
…andlers so that user can get all available CommandHandlers by request /api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's better to add an example to show how to register a customized CommandHandler
via SPI in sentinel-demo-command-handler
as it's a demo module.
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice, thanks for contributing! |
Describe what this PR does / why we need it
Add a ApiCommandHandler which fetch all registered CommandHandlers so that user can get all available CommandHandlers by request /api
Does this pull request fix one issue?
No. Only add new features
Describe how you did it
Create a new CommandHandler called ApiCommandHandler
Describe how to verify it