Enhancement/advanced metric extension tagging entrytype #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cdfive
added
area/metrics
|
Maybe we could just refactor the original |
sczyh30
reviewed
Jul 22, 2020
...el-core/src/main/java/com/alibaba/csp/sentinel/metric/extension/AdvancedMetricExtension.java
Show resolved
Hide resolved
sczyh30
reviewed
Jul 28, 2020
...el-core/src/main/java/com/alibaba/csp/sentinel/metric/extension/AdvancedMetricExtension.java
Show resolved
Hide resolved
|
It's recommended to submit another PR for flaky test cases in sentinel-demo-quarkus module (#1623) to keep the single PR pure :) |
Get it. I will close this PR. And summit two new ones. |
|
@Billzaifei Any progress regarding this PR? |
|
Created the new one #1665. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
For the below interface, We implement it to export prometheus metrics.
com.alibaba.csp.sentinel.metric.extension.MetricExtension
Take the method
addPass(String resource, int n, Object... args)for example.We want to distinguish [in] type from [out] type using it as the prometheus tag.
provider[in]/consumer[out]
Does this pull request fix one issue?
Resolves #1566
Describe how you did it
Enhance com.alibaba.csp.sentinel.metric.extension.MetricExtension with com.alibaba.csp.sentinel.metric.extension.AdvancedMetricExtension
Describe how to verify it
Run test cases.
Special notes for reviews