【WIP】Support setting class-level defaultFallback for annotation extension #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyuguang
changed the title
sczyh30
reviewed
May 13, 2020
| import org.springframework.stereotype.Service; | ||
|
|
||
| /** | ||
| * @author Eric Zhao | ||
| */ | ||
| @Service | ||
| @SentinelResource(defaultFallback = "defaultGlobalFallback", fallbackClass = {TestServiceImpl.class}) |
There was a problem hiding this comment.
For this sample, fallbackClass is not required according to the resolution strategy.
Comment on lines
+19
to
+20
| - `fallbackClass` The default fallback method in which class. | ||
| - supported class-level annotation (since 1.8.0), Effective when the class annotation `defaultFallback` is not empty; |
There was a problem hiding this comment.
Duplicate with the content above:
If you want to use method in other classes, you can set the
fallbackClasswith correspondingClass(Note the method in other classes must be static).
And it's effective for both fallback and defaultFallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1464
我现在把获取类注解的放在最上面了