Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentinel-cluster-client-redis #1226
sentinel-cluster-client-redis #1226
Changes from 7 commits
82c853a
a3269de
b183ab0
62bd406
5b3b9ae
0538549
de54ede
1e9b48b
28de029
ad1d7ef
5379777
00d6cfc
7943940
a3f6819
6b7da81
ad6a18d
8beb5fe
eea40eb
8ef9319
61625ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the loading process should not be put in client (or we call it proxy or util) and load when needed. This may cause racing or latency, right?
Better put them in kinds of initializing codes like InitFunc, etc
And the name
RedisClient
will cause ambiguous with real client of Redis.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redis加载工作确实在RedisClusterClientInitFunc#initJedisClient方法中RedisProcessorFactoryManager.setClientType完成。
RedisClient已改为RedisProcessor。