Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix when handling the end separator of the customized log directory in LogBase #1172

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

zhaoyuguang
Copy link
Collaborator

resolve #1169

@sczyh30 sczyh30 added the area/logging Issues or PRs related to logging of Sentinel label Nov 21, 2019
@codecov-io
Copy link

Codecov Report

Merging #1172 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1172      +/-   ##
============================================
- Coverage     42.87%   42.86%   -0.02%     
+ Complexity     1541     1539       -2     
============================================
  Files           330      330              
  Lines          9764     9764              
  Branches       1318     1318              
============================================
- Hits           4186     4185       -1     
  Misses         5064     5064              
- Partials        514      515       +1
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/alibaba/csp/sentinel/log/LogBase.java 56.94% <100%> (ø) 10 <0> (ø) ⬇️
...ava/com/alibaba/csp/sentinel/node/ClusterNode.java 96.55% <0%> (-3.45%) 10% <0%> (-1%)
...m/alibaba/csp/sentinel/log/DateFileLogHandler.java 54.54% <0%> (-3.04%) 6% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LeapArray.java 67.32% <0%> (-2.98%) 33% <0%> (-1%)
...p/sentinel/datasource/consul/ConsulDataSource.java 72.46% <0%> (+7.24%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a58f7...3c7be7d. Read the comment docs.

@sczyh30 sczyh30 merged commit 24f8d75 into alibaba:master Nov 21, 2019
@sczyh30 sczyh30 added this to the 1.7.1 milestone Nov 21, 2019
@sczyh30
Copy link
Member

sczyh30 commented Nov 21, 2019

Thanks!

hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Issues or PRs related to logging of Sentinel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when handling the end separator of the customized log directory in LogBase
3 participants