Refactored SentinelGrpcServerInterceptorTest #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
============================================
- Coverage 45.98% 45.84% -0.14%
+ Complexity 557 556 -1
============================================
Files 113 114 +1
Lines 3806 3813 +7
Branches 530 531 +1
============================================
- Hits 1750 1748 -2
- Misses 1846 1854 +8
- Partials 210 211 +1
Continue to review full report at Codecov.
|
sczyh30
requested changes
Aug 29, 2018
| GrpcTestServer() { | ||
| } | ||
|
|
||
| void prepare(int port) throws IOException { |
There was a problem hiding this comment.
Using the name start may be more appropriate.
|
|
||
| import java.io.IOException; | ||
|
|
||
| import static org.junit.Assert.*; |
| @@ -43,8 +39,8 @@ | |||
|
|
|||
| private final String resourceName = "com.alibaba.sentinel.examples.FooService/anotherHello"; | |||
| private final int threshold = 4; | |||
| private final GrpcTestServer extractedSentinelGrpcServerInterceptorTest = new GrpcTestServer(); | |||
There was a problem hiding this comment.
The name is too long, just grpcTestServer is okay.
…t' into feature/refactored-sentinel-grpc-server-interceptor-test # Conflicts: # sentinel-adapter/sentinel-grpc-adapter/src/test/java/com/alibaba/csp/sentinel/adapter/grpc/GrpcTestServer.java
sczyh30
requested changes
Aug 29, 2018
| } | ||
| ServerBuilder<?> serverBuild = ServerBuilder.forPort(port) | ||
| .addService(new FooServiceImpl()); | ||
| if(shouldintercept) |
There was a problem hiding this comment.
Please reformat your code with Alibaba P3C Plugin and obey the rules in Alibaba Java Coding Guidelines (naming, indent, format, etc.). For example:
if (shouldIntercept) {
serverBuilder.intercept(new SentinelGrpcServerInterceptor());
}
|
Hi @sczyh30 , reformatted the code. |
sczyh30
approved these changes
Aug 30, 2018
|
Nice, thanks for your contribution! |
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
- Added a GrpcTestServer to abstract common server logic - Refactor with new added `GrpcTestServer`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performed extract class operation for SentinelGrpcServerInterceptorTest. Extracted fields: server. Extracted Methods: prepareServer, stopServer.