Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more kinds of exception types when tracing exception count in Sentinel Dubbo Adapter #61

Closed
guonanjun opened this issue Aug 14, 2018 · 1 comment
Closed

Support more kinds of exception types when tracing exception count in Sentinel Dubbo Adapter #61

guonanjun opened this issue Aug 14, 2018 · 1 comment
Assignees
@sczyh30
Labels
kind/enhancement Category issues or prs related to enhancement.
Milestone
0.2.0

Comments

@guonanjun
Copy link
Contributor

Issue Description

Type: bug report

Describe what happened (or what feature you want)

使用sentinel-dubbo-adapter后，为资源设置熔断降级时，根据异常比例降级只支持RpcException，不支持其他RuntimeException。
default

Describe what you expected to happen

期望支持其他RuntimeException。
@guonanjun guonanjun changed the title 熔断降级的异常比例只支持RpcException，不支持其他RuntimeException [BUG]熔断降级的异常比例只支持RpcException，不支持其他RuntimeException Aug 14, 2018
@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Aug 14, 2018
@sczyh30 sczyh30 added this to the 0.2.0 milestone Aug 14, 2018
@sczyh30 sczyh30 self-assigned this Aug 14, 2018
@sczyh30 sczyh30 changed the title [BUG]熔断降级的异常比例只支持RpcException，不支持其他RuntimeException Support more kinds of exception types when tracing exception count in Sentinel Dubbo Adapter Aug 14, 2018
@sczyh30
Copy link
Member

sczyh30 commented Aug 14, 2018

Thanks for reporting! We'll fix this in 0.2.0.

Arlmls pushed a commit to Arlmls/Sentinel that referenced this issue Jan 8, 2019
@sczyh30
Resolves alibaba#61: Enhance exception trace in Sentinel Dubbo Adapter
30d2073 
Signed-off-by: Eric Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sczyh30 sczyh30

Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@sczyh30 @guonanjun