Fix wrong protobuf cmake variable when cmake < 3.6.0 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daquexian
force-pushed
the
fix_protobuf_cmake
branch
from
6c6a97f to
d6f097c
Compare
jxt1234
pushed a commit
that referenced
this pull request
Feb 17, 2025
Fix wrong protobuf cmake variable when cmake < 3.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to cmake doc, FindProtobuf.cmake defines
PROTOBUF_*instead ofProtobuf_*in cmake < 3.6, so cmake 3.5 users (including ubuntu 16.04 users which install cmake 3.5.1 byapt install) will get link errors like/usr/bin/ld: source/onnx/libonnx.so: undefined reference to google::protobuf::RepeatedField<unsigned long>::unsafe_data() const'and fail to build converter sinceProtobuf_*is empty.What's more, it's more proper to use
Protobuf_INCLUDE_DIRSinstead ofProtobuf_INCLUDE_DIRaccording to the doc, the latter one is expected to be set by the user and even doesn't exist in cmake 3.0, so I fixed it too.Refer: cmake 3.5 doc
cmake 3.6 doc
cmake 3.0 doc