check os compatibility and dependencies_version in prepare_env.sh #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighingnow
approved these changes
Jan 22, 2021
yecol
requested changes
Jan 22, 2021
There was a problem hiding this comment.
You may also want to revise the file in /docs, for https://graphscope.io/docs/installation.html
README.md
Outdated
|
|
||
| For Linux distributions, we provide a script to install the above dependencies and prepare the environment. | ||
| For Ubuntu/CentOs/WSL2, we provide a script to install the above dependencies and prepare the environment. |
|
Maybe also checking the platform's version? like Ubuntu 14, 16, 18? |
yecol
requested changes
Jan 25, 2021
thanks for the suggestion. this script can include MacOS prepare environment though kind i think, i will add this feature in next related pr after test. |
yecol
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
check os compatibility and dependencies_version in prepare_env.sh to improve "Getting Started" experience
Related issue number
Fixes #93