Skip to content

Try to read namespace from kube config when missing k8s_namesapce param #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

Try to read namespace from kube config when missing k8s_namesapce param #95

merged 2 commits into from
Jan 20, 2021

Conversation

lidongze0629
Copy link
Collaborator

What do these changes do?

Related issue number

Fixes #88

@sighingnow sighingnow self-requested a review January 18, 2021 10:50
sighingnow
sighingnow requested changes Jan 18, 2021
View reviewed changes
Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lidongze0629 Please also update the docstring for "namespace":

https://github.com/alibaba/GraphScope/blob/main/python/graphscope/client/session.py#L173

@sighingnow sighingnow self-requested a review January 20, 2021 05:57
@sighingnow sighingnow merged commit 2695b65 into alibaba:main Jan 20, 2021
@lidongze0629 lidongze0629 deleted the dz/namespace branch January 25, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yecol yecol yecol approved these changes

@sighingnow sighingnow sighingnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect the default value when missing k8s_namespace param in session
3 participants
@lidongze0629 @yecol @sighingnow